search

gmethvin / directory-watcher

A cross-platform Java recursive directory watcher, with a JNA macOS watcher and Scala better-files integration
Apache License 2.0
265 stars 34 forks source link

Add builder for DirectoryWatcher and pass Logger as parameter #18

Closed gmethvin closed 6 years ago

gmethvin commented 6 years ago

Fixes #12. Since there are a lot of parameters now I decided to switch to a builder pattern for creating the DirectoryWatcher.

The default logger when using the builder is still LoggerFactory.getLogger(DirectoryWatcher.class) but I'm considering maybe using a NOPLogger by default and providing an easy way to configure the static logger if you want. Open to change it based on feedback.

I also updated the better-files watcher to allow configuring file hashing and the logger.

gmethvin commented 6 years ago

Released 0.7.0.

olafurpg commented 6 years ago

Thank you @gmethvin Updated in https://github.com/olafurpg/mdoc/pull/58 and was able to remove logback.xml 🙏