gmetzker / serverless-plugin-lambda-dead-letter

serverless plugin that can configure a lambda with a dead letter queue or topic
MIT License
46 stars 15 forks source link

Serverless configuration validation warning #42

Open greenlynx opened 3 years ago

greenlynx commented 3 years ago

Serverless is throwing a warning when it validates its configuration before deployment:

Serverless: Configuration warning at 'functions.foo': unrecognized property 'deadLetter'

Excerpt from serverless.yml:

functions:
  foo:
    handler: src/handlers/events/foo.bar
    deadLetter:
      targetArn:
        GetResourceArn: DeadLetterQueue

According to the documentation for Service configuration validation:

If you received a configuration warning it could mean that:

  • Configuration related to external plugin does not have an associated JSON Schema. In such cases, please report the issue with the plugin author and provide them the details on how to extend validation schema in order to permanently correct the issue.

The same documentation page says that this warning is likely to become an error in future, which would break this plugin.

codezninja commented 3 years ago

@greenlynx does this method break for you? I see in method-1 where I have this plugin create the sqs queue with serverless 2.35. It creates the queue fine, but doesn't link the sqs queue the lambda as a dlq

FrazerBayley commented 3 years ago

Looks like the pattern for DLQ setup has been changed both in AWS and subsequently Serverless. See: https://www.serverless.com/blog/lambda-destinations

I think using this plugin is pretty much unsupported now. @bondezbond @greenlynx