search

gmggroup / omf-python

Python library for working with OMF files
MIT License
79 stars 20 forks source link

[GH-64] Build on properties.extras.HasUid #67

Closed fwkoch closed 5 years ago

fwkoch commented 5 years ago

Previously the UID behaviour was implemented custom within the python OMF implementation. See #64

This also adds a large number of trailing commas, for consistent style.

Note - This is the first OMFv2 PR to implement breaking changes from the v1 API.

codecov-io commented 5 years ago

Codecov Report

Merging #67 into dev will increase coverage by 2.24%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev      #67      +/-   ##
==========================================
+ Coverage   94.79%   97.03%   +2.24%     
==========================================
  Files          10       10              
  Lines         480      472       -8     
==========================================
+ Hits          455      458       +3     
+ Misses         25       14      -11
Impacted Files Coverage Δ
omf/surface.py 100% <ø> (ø) :arrow_up:
omf/texture.py 100% <ø> (ø) :arrow_up:
omf/lineset.py 100% <ø> (ø) :arrow_up:
omf/volume.py 100% <ø> (ø) :arrow_up:
omf/pointset.py 95.23% <ø> (ø) :arrow_up:
omf/data.py 100% <ø> (ø) :arrow_up:
omf/fileio.py 92.4% <100%> (+15.37%) :arrow_up:
omf/base.py 94.02% <100%> (-0.98%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d4f751d...fa9375d. Read the comment docs.

fwkoch commented 5 years ago

I am going to go ahead and merge this. Possibly some of the changes will be reverted with further OMFv2 development, especially when implementing the new ZIP file format. However, this gives us a cleaner base to work from moving forward.