Update SurfaceGrid API to ensure it is in line with new block models

gmggroup / omf-python

Python library for working with OMF files

MIT License

79 stars 19 forks source link

Update SurfaceGrid API to ensure it is in line with new block models #69

Open fwkoch opened 5 years ago

fwkoch commented 5 years ago

We need to make sure the SurfaceGrid API is updated for consistency with the new block model API. Also, worth considering if we need new "sub-gridded" surfaces, equivalent to octree/arbitrary sub blocks? Probably not but worth a discussion.

Inspired by @banesullivan's comment - https://github.com/gmggroup/omf/pull/65#discussion_r265816383

dbrookes96 commented 5 years ago

Having a RegularSurfaceGridElement would be useful as some grid formats only use regular spacing. Would it be possible to add support for delination/faults in these new Surface Grid elements. I'm not really sure how you would represent these. Maybe if Z == DBL_MAX or have a separate (optional) bool array alongside the Z values to specify if the cell exists.