fwkoch commented 5 years ago

Implement RegularSubBlockModel, as laid out in the prototype sketch here: https://github.com/gmggroup/omf/blob/dev/notebooks/omf_cbi.ipynb
Move old VolumeGridElement to TensorBlockModel
Pull out shared block model orientation properties / indexing functionality

fwkoch commented 5 years ago

Hey @cvasey, @dbrookes96, @rminhxm, @markgodresse, @jeremybutlermaptek, @bluetyson - Here is the first somewhat meaty PR up for review since getting you all on board to review. For a bit more context, you can take a look at the prototyping notebook linked in my previous comment. If you have comments on that, feel free to submit a review on the closed PR https://github.com/gmggroup/omf/pull/65 as well.

Let me know if you have any questions! For more general discussion I also created https://github.com/gmggroup/omf/issues/79

codecov-io commented 5 years ago

Codecov Report

Merging #78 into dev will decrease coverage by 1.56%. The diff coverage is 88.88%.

@@            Coverage Diff             @@
##              dev      #78      +/-   ##
==========================================
- Coverage   96.61%   95.05%   -1.57%     
==========================================
  Files          11       10       -1     
  Lines         502      586      +84     
==========================================
+ Hits          485      557      +72     
- Misses         17       29      +12

Impacted Files	Coverage Δ
omf/__init__.py	`100% <100%> (ø)`	:arrow_up:
omf/blockmodel.py	`90.96% <88.79%> (-4.16%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52dc6a9...7f3dce6. Read the comment docs.

gmggroup / omf-python

[GH-56] Regular SubBlock Model #78

Codecov Report