gmichels / terraform-provider-adguard

Terraform provider for AdGuard
https://registry.terraform.io/providers/gmichels/adguard/latest/docs
MIT License
9 stars 4 forks source link

RemoveResource for not existed resources #104

Closed sealbro closed 1 month ago

sealbro commented 1 month ago

Hi, @gmichels ! Thank you for the helpful provider

I had a problem when somebody removed resources from UI or used API. When it happens, you can't apply your changes and should add them, or nothing will apply.

What changed:

sealbro commented 1 month ago

Few screenshots

Delete not existing in adguard resources (terraform output)

image

make help command

image
gmichels commented 1 month ago

Hey @sealbro, thanks for the PR. Tests are failing on the cleanup you added, so they need reverted. I will also make some minor verbiage/cosmetic suggestions on the code.

gmichels commented 1 month ago

The tests have passed just fine. I will try to look further into why the timeout is happening, but for this PR, I believe we are looking good.

Thanks for the contribution.