search

gmit22 / pe

0 stars 0 forks source link

Details regarding equity value and profit in trades is not always clear. #5

Open gmit22 opened 3 years ago

gmit22 commented 3 years ago

Even though the profit/loss = 0 currently, on typing the command wallet it shows some loss. This may be due to api limit, however the user should not see incorrect information at any time. This differs from the behaviour, and would create some confusion.

It is confirmed by the display of 'view' command above it. Capture.PNG

nus-pe-bot commented 3 years ago

Team's Response

Market prices fluctuate by the second, our API calls are in real time and hence our profit and loss are also calculated in real time. Do see if this can explain the variations.

Wallet function calls the API as well so it is also because of the API limitation that made the app hard to use and test. However, should have reflected an error message.

Most of our functions calls the API, and because of the API request limit, many of our functions will not work if there are too many calls to the API, we agree that this has made it difficult for users to use the app efficiently and has caused some of our functions to constantly display the API limit error especially when the function requires more than 5 calls made to the API to be ran. We have tried to include caveats (such as setting the bookmarks limit to 5) it will still require users to wait for awhile before being able to run any other command. We could only fix these issues if we pay for the premium price for fetching stock data from that API, which we have also stated in our user guide.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your reason]