search

gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Update the NE flowsheet to use the new `MultiPeriodModel` class in IDAES #143

Closed radhakrishnatg closed 1 year ago

radhakrishnatg commented 2 years ago

Addresses issue:

112

Summary/Motivation:

Update the nuclear flowsheet to use the new MultiPeriodModel class and remove the multiperiod.py class from the DISPATCHES repo.

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov[bot] commented 1 year ago

Codecov Report

Base: 90.68% // Head: 90.82% // Increases project coverage by +0.14% :tada:

Coverage data is based on head (3267016) compared to base (04a9deb). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #143 +/- ## ========================================== + Coverage 90.68% 90.82% +0.14% ========================================== Files 54 54 Lines 5830 5919 +89 ========================================== + Hits 5287 5376 +89 Misses 543 543 ``` | [Impacted Files](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/143?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | Coverage Δ | | |---|---|---| | [...hes/case\_studies/nuclear\_case/nuclear\_flowsheet.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvbnVjbGVhcl9jYXNlL251Y2xlYXJfZmxvd3NoZWV0LnB5) | `100.00% <100.00%> (ø)` | | | [...udies/nuclear\_case/tests/test\_nuclear\_flowsheet.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvbnVjbGVhcl9jYXNlL3Rlc3RzL3Rlc3RfbnVjbGVhcl9mbG93c2hlZXQucHk=) | `100.00% <100.00%> (ø)` | | | [dispatches/unit\_models/hydrogen\_turbine\_unit.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy91bml0X21vZGVscy9oeWRyb2dlbl90dXJiaW5lX3VuaXQucHk=) | `100.00% <100.00%> (ø)` | | | [...patches/unit\_models/tests/test\_hydrogen\_turbine.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/143/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy91bml0X21vZGVscy90ZXN0cy90ZXN0X2h5ZHJvZ2VuX3R1cmJpbmUucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

radhakrishnatg commented 1 year ago

Thank you @dguittet and @jghouse88! @lbianchi-lbl Could you please merge this PR?