gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Idaes2update #156

Closed nareshsusarla closed 1 year ago

nareshsusarla commented 2 years ago

Addresses issue:

Addresses issues outlined in #153

Summary/Motivation:

Convergence of fossil case models and notebooks

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov[bot] commented 2 years ago

Codecov Report

Base: 92.13% // Head: 94.54% // Increases project coverage by +2.41% :tada:

Coverage data is based on head (482aeff) compared to base (6b905b1). Patch coverage: 97.79% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #156 +/- ## ========================================== + Coverage 92.13% 94.54% +2.41% ========================================== Files 55 55 Lines 6039 6107 +68 ========================================== + Hits 5564 5774 +210 + Misses 475 333 -142 ``` | [Impacted Files](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | Coverage Δ | | |---|---|---| | [...ant/storage/tests/test\_discharge\_usc\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL3Rlc3RzL3Rlc3RfZGlzY2hhcmdlX3VzY19wb3dlcnBsYW50LnB5) | `100.00% <ø> (+30.18%)` | :arrow_up: | | [...lant/storage/multiperiod\_integrated\_storage\_usc.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL211bHRpcGVyaW9kX2ludGVncmF0ZWRfc3RvcmFnZV91c2MucHk=) | `93.00% <96.00%> (+3.11%)` | :arrow_up: | | [...ischarge\_design\_ultra\_supercritical\_power\_plant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL2Rpc2NoYXJnZV9kZXNpZ25fdWx0cmFfc3VwZXJjcml0aWNhbF9wb3dlcl9wbGFudC5weQ==) | `95.26% <100.00%> (+36.24%)` | :arrow_up: | | [...ted\_storage\_with\_ultrasupercritical\_power\_plant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL2ludGVncmF0ZWRfc3RvcmFnZV93aXRoX3VsdHJhc3VwZXJjcml0aWNhbF9wb3dlcl9wbGFudC5weQ==) | `93.09% <100.00%> (-1.19%)` | :arrow_down: | | [...ted\_storage\_with\_ultrasupercritical\_power\_plant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL3Rlc3RzL3Rlc3RfaW50ZWdyYXRlZF9zdG9yYWdlX3dpdGhfdWx0cmFzdXBlcmNyaXRpY2FsX3Bvd2VyX3BsYW50LnB5) | `92.85% <100.00%> (ø)` | | | [...e/tests/test\_multiperiod\_integrated\_storage\_usc.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL3Rlc3RzL3Rlc3RfbXVsdGlwZXJpb2RfaW50ZWdyYXRlZF9zdG9yYWdlX3VzYy5weQ==) | `100.00% <100.00%> (ø)` | | | [...ercritical\_plant/ultra\_supercritical\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/156/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC91bHRyYV9zdXBlcmNyaXRpY2FsX3Bvd2VycGxhbnQucHk=) | `98.51% <100.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.