Closed lbianchi-lbl closed 1 year ago
@joshua-cogliati-inl I've added the following step to clone the RAVEN repository and run one of the examples as suggested by @radhakrishnatg: https://github.com/gmlc-dispatches/dispatches/blob/ad82bd1242fe498abbdfa1b1ace60c0457ff4038/.github/workflows/raven-integration.yml#L51-L60
However, this seems to open a GUI window that must be closed manually for the process to terminate, which makes it hard to use this in CI. Is there a way to run RAVEN in "batch mode", so that the raven_framework
command terminates without manual intervention? I've tried raven_framework --help
and the website to see if I could find something like this, but without luck.
I would recommend a different test (doc/workshop/forwardSampling/exercises/1_sample_and_plot.xml
plots to screen
) such as tests/framework/user_guide/ForwardSamplingStrategies/forwardSamplingGrid.xml
if additional (simple) TEAL tests are of interest, I would recommend TEAL/tests/Cash_Flow_input_NPV.xml
. an additional one that might pertain more to #150 would be TEAL/tests/PyomoTest.py
(both found here)
@lbianchi-lbl
python -c "
from raven.ravenframework.utils import xmlUtils; print(xmlUtils)
from raven.scripts import externalROMLoader; print(externalROMLoader)
"
This should probably be:
python -c "
from ravenframework.utils import xmlUtils; print(xmlUtils)
from ravenframework import ROMExternal; print(ROMExternal)
"
If there is code still using externalROMLoader let me know and I can suggest how to modify it to switch to ROMExternal.
The pip package installs RAVEN into ravenframework, not raven (There was already a different raven in pip)
Thanks.
If there is code still using externalROMLoader let me know and I can suggest how to modify it to switch to ROMExternal. The pip package installs RAVEN into ravenframework, not raven (There was already a different raven in pip)
Thanks for looking into this @joshua-cogliati-inl. For the import checks, my approach was to look at #150 and collect any RAVEN/TEAL imports used there. In particular, the externalROMLoader
is taken from:
Thanks, I left some review comments over at that pull request.
We released raven-framework 2.2 , so can you switch requirements-raven.txt to use that instead of the release candidate? I think that should fix at least one of the failures.
We released raven-framework 2.2 , so can you switch requirements-raven.txt to use that instead of the release candidate? I think that should fix at least one of the failures.
@joshua-cogliati-inl thanks, I was just about to post that https://github.com/idaholab/raven/commits/devel/ravenframework/ROMExternal.py seems to have been added recently and therefore was probably not included in the code version that was being used here. I'll update the requirements with the non-RC version.
Base: 93.69% // Head: 93.69% // Decreases project coverage by -0.00%
:warning:
Coverage data is based on head (
91ff131
) compared to base (bcbaba8
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The notebook execution checks are failing because of #167, but I think we should merge this anyway since the failures are not related to the content of this PR.
Resolves: #76
Summary/Motivation:
Changes proposed in this PR:
requirements-raven.txt
fileLegal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: