gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Update idaes-pse requirement to 2.0.0bx #164

Closed lbianchi-lbl closed 1 year ago

lbianchi-lbl commented 1 year ago

Addresses issue:

Summary/Motivation:

Check if anything breaks with IDAES 2.0.0bx and Pyomo 6.4.3

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
lbianchi-lbl commented 1 year ago

On top of the test failures common to #161, the CI runs are showing additional errors that seem to originate from GDPopt: EDIT that was incorrect, the same errors happen on #161 as well

image

Note that unlike #161, this PR introduce a dependency (through IDAES) to Pyomo 6.4.3.

codecov[bot] commented 1 year ago

Codecov Report

Base: 93.69% // Head: 93.69% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (9892708) compared to base (bcbaba8). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== - Coverage 93.69% 93.69% -0.01% ========================================== Files 59 59 Lines 7105 7104 -1 ========================================== - Hits 6657 6656 -1 Misses 448 448 ``` | [Impacted Files](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | Coverage Δ | | |---|---|---| | [...a\_supercritical\_plant/tests/test\_usc\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC90ZXN0cy90ZXN0X3VzY19wb3dlcnBsYW50LnB5) | `100.00% <ø> (ø)` | | | [...ischarge\_design\_ultra\_supercritical\_power\_plant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL2Rpc2NoYXJnZV9kZXNpZ25fdWx0cmFfc3VwZXJjcml0aWNhbF9wb3dlcl9wbGFudC5weQ==) | `95.26% <100.00%> (ø)` | | | [...ant/storage/tests/test\_discharge\_usc\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL3Rlc3RzL3Rlc3RfZGlzY2hhcmdlX3VzY19wb3dlcnBsYW50LnB5) | `100.00% <100.00%> (ø)` | | | [dispatches/unit\_models/elec\_splitter.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy91bml0X21vZGVscy9lbGVjX3NwbGl0dGVyLnB5) | `95.79% <100.00%> (-0.04%)` | :arrow_down: | | [dispatches/unit\_models/tests/test\_concrete\_tes.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy91bml0X21vZGVscy90ZXN0cy90ZXN0X2NvbmNyZXRlX3Rlcy5weQ==) | `83.53% <100.00%> (ø)` | | | [...ches/unit\_models/tests/test\_heat\_exchanger\_tube.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy91bml0X21vZGVscy90ZXN0cy90ZXN0X2hlYXRfZXhjaGFuZ2VyX3R1YmUucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.