gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Raven and Teal integration #177

Closed radhakrishnatg closed 1 year ago

radhakrishnatg commented 1 year ago

Addresses issue:

86 and #90

Summary/Motivation:

This PR replaces #150

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
lbianchi-lbl commented 1 year ago

@radhakrishnatg I tried running the notebook through the test framework locally in a Windows VM in an environment where RAVEN and TEAL are installed. It seems to run just fine, but then ultimately fails because of one of the cells exceeding the default timeout (2000 s -> ~30 min). Is this in line with the runtime you get when running locally? Is there any way this example could be tweaked so that the notebook executes in 10 minutes or so?

image

radhakrishnatg commented 1 year ago

@lbianchi-lbl I could run all the cells in the notebook within 10 minutes on my local machine. I do not know why that cell is taking more than half an hour. Also, I'm running the simplest case possible in that cell. So, could you please try running the notebook once again and let me know if it still takes longer than half an hour?

lbianchi-lbl commented 1 year ago

@radhakrishnatg OK, I see. I've tried re-running and the results are the same. I guess my resource-starved VM might be to blame, in which case we could just check how long it takes on the GHA runners. In the off-chance that some package version might be affecting that, could you run pip list in your local environment and paste the output here?

radhakrishnatg commented 1 year ago

@lbianchi-lbl I do not have my work laptop (which I used to run the notebook) with me. I will be out of office starting tomorrow and I will be back Thursday of next week. Is there any other thing I could try to know what is causing it take more time? Also, the cell which is causing the issue is also present in the multiperiod_design_pricetaker.ipynb notebook. It is strange why it can run in less than 30 min in the other notebook but not in this notebook.

lbianchi-lbl commented 1 year ago

@radhakrishnatg No worries, I can look into it. Worst case, we can skip that cell since the RAVEN/TEAL setup happens in the first cells (which seem to run just fine).

Also, good point about multiperiod_design_pricetaker.ipynb - I can try to run the same exact command using that notebook and see if the long runtime also occurs.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (b243bfa) 93.74% compared to head (cbeef5b) 93.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #177 +/- ## ======================================= Coverage 93.74% 93.74% ======================================= Files 59 59 Lines 7130 7130 ======================================= Hits 6684 6684 Misses 446 446 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lbianchi-lbl commented 1 year ago

It looks like running the TEAL notebook in CI mostly works, but there seems to be a solver error causing cells 28 and 29 to fail.

Given that:

I'll go ahead and merge this after having:

joshua-cogliati-inl commented 1 year ago

Thank you @lbianchi-lbl