search

gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

updates to the FE case models with new Pyomo #179

Closed nareshsusarla closed 1 year ago

nareshsusarla commented 1 year ago

Addresses issue:

This PR addresses the issues in FE case study design files caused due to the updated NL writer in the new Pyomo

Summary/Motivation:

Changes proposed in this PR:

-

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
nareshsusarla commented 1 year ago

the tests are failing because of the Jupyter notebook for RE case double loop optimization

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 :tada:

Comparison is base (d44985e) 93.69% compared to head (dd8260c) 93.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #179 +/- ## ========================================== + Coverage 93.69% 93.74% +0.05% ========================================== Files 59 59 Lines 7104 7130 +26 ========================================== + Hits 6656 6684 +28 + Misses 448 446 -2 ``` | [Impacted Files](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | Coverage Δ | | |---|---|---| | [dispatches/\_\_init\_\_.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9fX2luaXRfXy5weQ==) | `100.00% <ø> (ø)` | | | [...se/supercritical\_plant/supercritical\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2Uvc3VwZXJjcml0aWNhbF9wbGFudC9zdXBlcmNyaXRpY2FsX3Bvd2VycGxhbnQucHk=) | `83.24% <ø> (ø)` | | | [...e/supercritical\_plant/tests/test\_scpc\_flowsheet.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2Uvc3VwZXJjcml0aWNhbF9wbGFudC90ZXN0cy90ZXN0X3NjcGNfZmxvd3NoZWV0LnB5) | `100.00% <ø> (ø)` | | | [...ted\_storage\_with\_ultrasupercritical\_power\_plant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL3Rlc3RzL3Rlc3RfaW50ZWdyYXRlZF9zdG9yYWdlX3dpdGhfdWx0cmFzdXBlcmNyaXRpY2FsX3Bvd2VyX3BsYW50LnB5) | `92.85% <ø> (ø)` | | | [...e/tests/test\_multiperiod\_integrated\_storage\_usc.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC9zdG9yYWdlL3Rlc3RzL3Rlc3RfbXVsdGlwZXJpb2RfaW50ZWdyYXRlZF9zdG9yYWdlX3VzYy5weQ==) | `100.00% <ø> (ø)` | | | [...a\_supercritical\_plant/tests/test\_usc\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC90ZXN0cy90ZXN0X3VzY19wb3dlcnBsYW50LnB5) | `100.00% <ø> (ø)` | | | [...ercritical\_plant/ultra\_supercritical\_powerplant.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvZm9zc2lsX2Nhc2UvdWx0cmFfc3VwZXJjcml0aWNhbF9wbGFudC91bHRyYV9zdXBlcmNyaXRpY2FsX3Bvd2VycGxhbnQucHk=) | `98.51% <ø> (ø)` | | | [...hes/case\_studies/nuclear\_case/nuclear\_flowsheet.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvbnVjbGVhcl9jYXNlL251Y2xlYXJfZmxvd3NoZWV0LnB5) | `100.00% <ø> (ø)` | | | [...udies/nuclear\_case/tests/test\_nuclear\_flowsheet.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvbnVjbGVhcl9jYXNlL3Rlc3RzL3Rlc3RfbnVjbGVhcl9mbG93c2hlZXQucHk=) | `100.00% <ø> (ø)` | | | [...es/case\_studies/renewables\_case/load\_parameters.py](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvcmVuZXdhYmxlc19jYXNlL2xvYWRfcGFyYW1ldGVycy5weQ==) | `100.00% <ø> (ø)` | | | ... and [49 more](https://codecov.io/gh/gmlc-dispatches/dispatches/pull/179?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lbianchi-lbl commented 1 year ago

@nareshsusarla @dguittet it looks like the only failing test is the RE DoubleLoopOptimization.ipynb timeout that should be handled by #181. Were you planning on making additional changes to this PR? Otherwise, I'll merge it in and verify that no failures remain in #181.