search

gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Address RE DoubleLoopOptimization.ipynb timeouts (clone of #181) #190

Closed lbianchi-lbl closed 1 year ago

lbianchi-lbl commented 1 year ago

Addresses issue: #176

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (170f534) 93.74% compared to head (350f064) 93.74%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ======================================= Coverage 93.74% 93.74% ======================================= Files 59 59 Lines 7130 7130 ======================================= Hits 6684 6684 Misses 446 446 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lbianchi-lbl commented 1 year ago

I think this is ready to merge as-is. Initially I thought we'd have to set the cell timeout higher than the current 600 s, but after checking the per-cell runtimes (shown at the end of the pytest --nbcheck=exec step), I think we can keep it to the current value and increase it if we see that we start getting failures again.