search

gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Add more tests to dynamic surrogates #206

Closed Xinhe-Chen closed 1 year ago

Xinhe-Chen commented 1 year ago

Addresses issue:

Summary/Motivation:

Add more tests to dynamic surrogates. This PR is created for https://github.com/gmlc-dispatches/dispatches/issues/195

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
Xinhe-Chen commented 1 year ago

Still working in progress. I will get this PR ready for review before the RC.

lbianchi-lbl commented 1 year ago

@Xinhe-Chen @dguittet: see IDAES/idaes-pse#1200 for the pytest issue.

lbianchi-lbl commented 1 year ago

@lbianchi-lbl and @Xinhe-Chen will touch base to solve the general testing issue this week.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 95.58% and project coverage change: +0.19 :tada:

Comparison is base (e1771b4) 89.49% compared to head (e265596) 89.69%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #206 +/- ## ========================================== + Coverage 89.49% 89.69% +0.19% ========================================== Files 67 67 Lines 8238 8303 +65 ========================================== + Hits 7373 7447 +74 + Misses 865 856 -9 ``` | [Impacted Files](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | Coverage Δ | | |---|---|---| | [...t\_surrogates/dynamic/tests/test\_Simulation\_Data.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy93b3JrZmxvdy90cmFpbl9tYXJrZXRfc3Vycm9nYXRlcy9keW5hbWljL3Rlc3RzL3Rlc3RfU2ltdWxhdGlvbl9EYXRhLnB5) | `97.90% <87.50%> (-2.10%)` | :arrow_down: | | [...arket\_surrogates/dynamic/Time\_Series\_Clustering.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy93b3JrZmxvdy90cmFpbl9tYXJrZXRfc3Vycm9nYXRlcy9keW5hbWljL1RpbWVfU2VyaWVzX0NsdXN0ZXJpbmcucHk=) | `37.67% <100.00%> (+1.98%)` | :arrow_up: | | [...n\_market\_surrogates/dynamic/Train\_NN\_Surrogates.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy93b3JrZmxvdy90cmFpbl9tYXJrZXRfc3Vycm9nYXRlcy9keW5hbWljL1RyYWluX05OX1N1cnJvZ2F0ZXMucHk=) | `28.75% <100.00%> (+1.18%)` | :arrow_up: | | [...gates/dynamic/tests/test\_Time\_Series\_Clustering.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy93b3JrZmxvdy90cmFpbl9tYXJrZXRfc3Vycm9nYXRlcy9keW5hbWljL3Rlc3RzL3Rlc3RfVGltZV9TZXJpZXNfQ2x1c3RlcmluZy5weQ==) | `99.24% <100.00%> (+0.16%)` | :arrow_up: | | [...rrogates/dynamic/tests/test\_Train\_NN\_Surrogates.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy93b3JrZmxvdy90cmFpbl9tYXJrZXRfc3Vycm9nYXRlcy9keW5hbWljL3Rlc3RzL3Rlc3RfVHJhaW5fTk5fU3Vycm9nYXRlcy5weQ==) | `98.64% <100.00%> (+0.34%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/206/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.