search

gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

Fix RE Notebook for Issue 200 #211

Closed dguittet closed 1 year ago

dguittet commented 1 year ago

Addresses issue:

200

Summary/Motivation:

Changes proposed in this PR:

-

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.01 :warning:

Comparison is base (688999d) 89.76% compared to head (f28fc86) 89.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #211 +/- ## ========================================== - Coverage 89.76% 89.76% -0.01% ========================================== Files 74 74 Lines 8854 8853 -1 ========================================== - Hits 7948 7947 -1 Misses 906 906 ``` | [Impacted Files](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches) | Coverage Δ | | |---|---|---| | [...bles\_case/RE\_surrogate\_optimization\_steadystate.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvcmVuZXdhYmxlc19jYXNlL1JFX3N1cnJvZ2F0ZV9vcHRpbWl6YXRpb25fc3RlYWR5c3RhdGUucHk=) | `91.51% <ø> (-0.06%)` | :arrow_down: | | [...tudies/renewables\_case/tests/test\_surrogate\_opt.py](https://app.codecov.io/gh/gmlc-dispatches/dispatches/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=gmlc-dispatches#diff-ZGlzcGF0Y2hlcy9jYXNlX3N0dWRpZXMvcmVuZXdhYmxlc19jYXNlL3Rlc3RzL3Rlc3Rfc3Vycm9nYXRlX29wdC5weQ==) | `73.91% <ø> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lbianchi-lbl commented 1 year ago

@dguittet I'm looking into the Linux "Notebooks checks" failures. They are very puzzling, as it looks like it's failing to find pytest plugins, and this is something I'd really not expect to be platform specific. I'll try to reproduce the error on a separate PR and keep you posted.

EDIT: these should have been addressed by #212.