gmlc-dispatches / dispatches

Primary repository for distributed dispatches software tools
https://dispatches.readthedocs.io/
Other
12 stars 34 forks source link

DISPATCHES Cleanup #222

Open MarcusHolly opened 8 months ago

MarcusHolly commented 8 months ago

Summary/Motivation:

Replacement of #217. Other contributors were unable to push commits into that PR, so we'll continue the effort on this PR.

Description from #217: This PR adds all work in progress files for the FE case study that addresses the following aspects:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.md and COPYRIGHT.md file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.
MarcusHolly commented 8 months ago

I believe all the double loop files are "working" now, but nlp_multiperiod_usc_static_doubleloop.py is still running into some issues. It exceeds the max number of iterations and the solver enters restoration. Adding scaling didn't resolve the issue (or help at all from what I could tell), so I just removed it. It's still able to generate the plots for whatever that's worth... any advice on this would be appreciated.

As for run_double_loop_usc.py, I just need to double check that it solves with Gurobi, but I haven't had the time to pull that up and run it yet.

Otherwise, I think the double loop files are good-to-go.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a9e9b7a) 89.83% compared to head (07212b3) 89.83%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #222 +/- ## ======================================= Coverage 89.83% 89.83% ======================================= Files 77 77 Lines 9307 9307 ======================================= Hits 8361 8361 Misses 946 946 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

MarcusHolly commented 8 months ago

Some files are duplicated - namely multiperiod_double_loop_usc.py and multiperiod_integrated_storage_usc.py. Both of these files appear inside of and outside of the double_loop folder. I've only updated the files inside the double loop folder, and when I tried to update the files outside of the double loop folder (just copying and pasting the files that I did edit already), the tests fail. Since we don't have the time to fix this now, I'll just make note of it here. I'm also not sure which of the duplicates should stay and which should be deleted because I doubt we actually want these duplicate files.