search

gmm96 / KDE-5-Template-Manager

KDE 5 Dolphin Service Menu for creating a template from an existing file or directory.
https://store.kde.org/p/1454391/
GNU General Public License v3.0
13 stars 5 forks source link

Fix icons used in project #5

Closed Ashark closed 3 years ago

Ashark commented 3 years ago

Currently in TermplateManager.desktop the icon for main file is favorite. Probably should instead use the project's one TemplateManagerIcon.png. I guess it should be placed at some standard location (do not yet explored which exactly) by install.sh and then use its name in Icon= field. Specifying absolute path to png works (in Dolphin the icon of the .desktop file itself changes), but using $HOME variable there does not work. So I am not sure for now how to implement it. This icon is referenced also in install.sh and in uninstall.sh.

Some other icons are missing in my system. For example, xapp-favorite-symbolic in cuttlefish shows nothing. It is referenced in TemplateManager.desktop and in TemplateManagerTools.sh.

gmm96 commented 3 years ago

To be honest, I have tried using the project's icon in the main service menu specifying absolute path to png file, but it always displays the icon corresponding to the first action in the menu (template creator). This is only happening on the service menu, you can properly see the icon navigating to the directory that keeps the service menu files using Dolphin. I don't know if it is currently a bug of Dolphin.

I was looking for a tool to check if certain icon exists in system, but without success. Maybe, I should use more common icons, like the ones used in template editor (edit) and template eraser (delete). Favorite icon may solve this issue.

gmm96 commented 3 years ago

Well, command kf5-config --path icon is currently working in my system, so I suppose I can give it another try installing the icon in one of these directories. On the other hand, I don't understand why some kf5-config --path arguments goes in singular (icon) and others in plural (templates), but it is ok.

gmm96 commented 3 years ago

After another look, xdg-icon-resource seems to be the right command to (un)install icons in system.

Ashark commented 3 years ago

I don't know if it is currently a bug of Dolphin.

Probably yes, I also experience this. I did not yet searched or reported in bugs.kde.org

I was looking for a tool to check if certain icon exists in system

You mean at runtime of the script? Or for you at develop time to choose an icon? If latter, then use Cuttlefish application.

gmm96 commented 3 years ago

You mean at runtime of the script? Or for you at develop time to choose an icon? If latter, then use Cuttlefish application.

I mean at runtime, so I would have alternatives to show if one icon is not installed in a system. Well, I'm gonna move to more common icons (favorite, edit, delete), which I expect they'll be already installed in every system, and then will try custom png icons.

gmm96 commented 3 years ago

Added more common icons in this https://github.com/gmm96/KDE-5-Template-Manager/commit/9c38b8693c04c207177042fa09030a4305d0c185. Closing this issue.