Closed ReedClanton closed 6 months ago
Hey @ReedClanton. Thanks for this.
Could be a leftover of some early experiments with doc generation. Annoying that it was only caught at runtime.
I have not been able to reproduce (all my dev/testing systems build with documentation.nixos.includeAllModules=true
).
Regardless, I like that you streamlined documentation functions. Will merge.
I have not been able to reproduce (all my dev/testing systems build with
documentation.nixos.includeAllModules=true
).
That's baffling. I can reproduce it on 3 machines. Given they all use the same base configuration.
Description
Two issue existed with the options documentation that caused build failures when
documentation.nixos.enable
anddocumentation.nixos.includeAllModules
are set totrue
.The first issue was that
mkDoc
was used rather thanlib.mdDoc
in two locations.mkDoc
isn't valid, so I replaced both instances of it withlib.mdDoc
.The second issue was that not all options of
nix-flatpak
had descriptions. This also causes a build failure.In addition to fixing the two issues above that cause build failures, I also:
README.md
.Why Wasn't it Noticed Sooner
By default
documentation.nixos.enable
istrue
anddocumentation.nixos.includeAllModules
isfalse
. The latter value used to default totrue
, but was changed due to build performance concerns for NixOps users. Having said that, there has been discussion of turning the default back totrue
for non NixOps users. If this is done, then everyone who uses this module will end up with broken system builds.In short, I noticed first because I was the first person to use this module and set
documentation.nixos.includeAllModules
totrue
.