search

gmostert / ng2-breadcrumb

This is an angular 2 component that creates a breadcrumb trail. It hooks into the angular2/router, to dynamically build up the crumb trail once a component is routed to.
MIT License
102 stars 81 forks source link

separate css/html from component. #32

Closed malindamiller closed 7 years ago

malindamiller commented 7 years ago

this commit fixes #9 and #24 " separated the css and html code into different files to follow ng2 coding standards.

gmostert commented 7 years ago

Thank you for your efforts, its always nice to see other people taking the time to improve the quality of software in general. However I'm not going to merge in these changes. The issue was never splitting out the assets, its building and bundling them in such a way that they are portable. I would need to change the entire build system in order for these standalone files to be included in the source of the released bundle. Alas this is beyond the scope of what I intended for this component, especially seeing how the current structure is still fully functional.