gmosx / kraken-sdk-rust

A Rust SDK for working with Kraken APIs
Apache License 2.0
23 stars 14 forks source link

rest client: feat: Add `expiretm` to User-Trading/operation/addOrder #29

Closed gitmalong closed 10 months ago

gitmalong commented 11 months ago

Hi!

Currently the add limit order fn does not support adding an expire timestamp.

https://docs.kraken.com/rest/#tag/User-Trading/operation/addOrder

And a general question: Have you considered to auto-generate certain API calls and structs with help of the OpenAPI JSON?

gmosx commented 11 months ago

The OpenAPI suggestion is interesting. I don't have much time at the moment, but I would appreciate it if you could open a separate issue just for that.

gmosx commented 10 months ago

Seems to me that expiretm is supported.

gmosx commented 10 months ago

Added support for effective/expire time in WS client. 'REST' client already supports this.