gmr / flatdict

Python module for interacting with nested dicts as a single level dict with delimited keys.
https://flatdict.readthedocs.io
BSD 3-Clause "New" or "Revised" License
112 stars 32 forks source link

Fix for performance issue in as_dict function #53

Open samander opened 1 year ago

samander commented 1 year ago

Original function takes 3 seconds to run new test_as_dict_perf() test. Updated code has performance inline with flatterdict as_dict implementation. flatterdict.as_dict code was used to model fix in flatdict.as_dict

tested: flake8 coverage run coverage report coverage xml

samander commented 1 year ago

@gmr PR is ready for review

samander commented 1 year ago

Hit this multiple times. I am having to locally fix it. Not ideal. Would be nice to get this fixed in the main repo