specification: only warns instead of raise DeprecationWarning

gmr / pamqp

Low level AMQP frame encoding and decoding library

https://pamqp.readthedocs.io

BSD 3-Clause "New" or "Revised" License

50 stars 20 forks source link

Closed dzen closed 5 years ago

dzen commented 5 years ago

Updates codegen tool to mention the method as deprecated, instead of hardly raise a DeprecationWarning

michaelklishin commented 5 years ago

@gmr this makes sense to me. I don't think any other client straight raises an error, although we may start doing that closer to the 4.0 release.

dzen commented 5 years ago

@michaelklishin a 4.0 release ? I only see a 2.0 release

michaelklishin commented 5 years ago

Sorry, I meant RabbitMQ 4.0 and what is going to happen (but hasn't yet) in a few clients developed by our team ;)

I think it's a sensible change for now.

gmr commented 5 years ago

LGTM :) Thanks, will release a new version today.