Change severity of a log message to logging.DEBUG

gmr / rabbitpy

A pure python, thread-safe, minimalistic and pythonic RabbitMQ client library

http://rabbitpy.readthedocs.org

BSD 3-Clause "New" or "Revised" License

242 stars 58 forks source link

Change severity of a log message to logging.DEBUG #22

Closed brimcfadden closed 10 years ago

brimcfadden commented 10 years ago

The 'Exiting IO.run' log message is now emitted with the DEBUG severity, matching the severity of the very similar message that occurs in IOLoop.run.

brimcfadden commented 10 years ago

What the purpose of rabbitpy.DEBUG? I continued to check it, for consistency, but shouldn't the logger be configured to emit at certain levels by the application? Why the extra check/line of code at each instance?

gmr commented 10 years ago

When your logging level is > DEBUG, there are still 2-3 evaluations that take place in logging prior to rejecting the logging request. DEBUG just micro-optimizes not making the extra calls in expensive places.

Thanks for the PR!