gms-bbg / gamess-issues

GAMESS issue tracking
7 stars 1 forks source link

Issues in lked and rungms #18

Open tomoppe opened 4 years ago

tomoppe commented 4 years ago

Dear Sir:

GAMESS version: September 30, 2019 R2 Public Release

lked, lines 823-825 I may have gotten lost in the complexity of the script, but is there an extraneous "endif" in lines 823-825?

Tom Oppe

Make sure these boxes are checked before submitting your issue - thank you!

saromleang commented 4 years ago

From a brief look it is very possible that there may be an extra "endif". Is this cause the script to not function properly? If so, what system are you getting this behavior on?

tomoppe commented 4 years ago

I have not seen the script misbehave. I just could not locate the corresponding "if" statement.

-----Original Message----- From: S. Leang [mailto:notifications@github.com] Sent: Tuesday, January 21, 2020 11:17 AM To: gms-bbg/gamess-issues gamess-issues@noreply.github.com Cc: Oppe, Thomas C ERDC-RDE-ITL-MS Contractor Thomas.C.Oppe@erdc.dren.mil; Author author@noreply.github.com Subject: Re: [gms-bbg/gamess-issues] Issues in lked and rungms (#18)

From a brief look it is very possible that there may be an extra "endif". Is this cause the script to not function properly? If so, what system are you getting this behavior on?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub Blockedhttps://github.com/gms-bbg/gamess-issues/issues/18?email_source=notifications&email_token=AMLWS3F3FPWAPH63JR6KS2TQ64U2TA5CNFSM4KJSEUY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQQ4DY#issuecomment-576785935Blocked , or unsubscribe Blockedhttps://github.com/notifications/unsubscribe-auth/AMLWS3CSJGYZSESSQY2NNBLQ64U2TANCNFSM4KJSEUYQBlocked . Blockedhttps://github.com/notifications/beacon/AMLWS3A6REY2J2YHGWUSQ4DQ64U2TA5CNFSM4KJSEUY2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJQQ4DY.gifBlocked

colleeneb commented 4 years ago

From testing, it looks like csh just ignores extraneous endifs. After inspection, I agree that it's extraneous. I'll submit a PR and test more in practice later tonight

saromleang commented 4 years ago

From testing, it looks like csh just ignores extraneous endifs. After inspection, I agree that it's extraneous. I'll submit a PR and test more in practice later tonight

I can address this in saromleang/build-support