gmsoft-tuxicoman / bt-audio

Use a linux PC as a bluetooth speaker
GNU General Public License v3.0
79 stars 13 forks source link

add volume control to pipeline #4

Closed itsb closed 10 months ago

itsb commented 11 months ago

Addresses #2.

gmsoft-tuxicoman commented 11 months ago

Thanks for your patch. Wouldn't it be best to change the volume porperty of the sink instead of changing the volume of the audio ?

Moreover, there are scenario where you don't want volume control if it's handled separately. For example I use a script that uses the volume properties and sends the right serial commands to my sound system. Please add an option in the arguments to disable it.

itsb commented 11 months ago

The alsa sink currently in use does not seem to expose volume control, see docs. That said, I was able to use sink volume control with the pulse audio sink added in this fork, see pulsesink docs. Please let me know how you want to proceed. Should we merge the pulseaudio toggle first and then add the volume toggle?

gmsoft-tuxicoman commented 11 months ago

Sure pulse audio toggle works for me. We can commit that first. However pulse audio already has support for BT and volume support, make sure they don't interfere.

itsb commented 11 months ago

cherry-picked Hubert's --pulse toggle, and added my --volcon toggle on top

gmsoft-tuxicoman commented 10 months ago

Thanks !