search

gmunguia / markdown-it-plantuml

:herb: :book: plantuml diagrams in your markdown
MIT License
98 stars 21 forks source link

enable setting server option from VS Code when used as extension by Markdown PDF extension #12

Closed imuni4fun closed 3 years ago

imuni4fun commented 5 years ago

The example shows how to set options from javascript, but this is an awesome extension for VS Code using Markdown PDF extension. It would be great to be able to set a setting for this extension so it could direct to a private PlantUML server. I have to export to HTML, replace all URLs, and then print to PDF at the moment as a work around. In addition, the ability to strip the "/plantuml" from the url would be great. This would allow easy use with plantuml docker images as shown in the following examples:

docker: docker run -d -p 8080:8080 plantuml/plantuml-server:tomcat currently generated: "http://www.plantuml.com/plantuml/svg/---sensitive---" desired generated: "http://localhost:8080/svg/---sensitive---"

FrVaBe commented 4 years ago

I think this issue should be reported to the vscode-markdown-pdf project, because this is the plugin which uses markdown-it-plantuml and needs to support the configuration of the server option which is provided here.

Therefore I opened a corresponding issue there see #139.

gmunguia commented 3 years ago

Closed as per the above.