gmunguia / markdown-it-plantuml

:herb: :book: plantuml diagrams in your markdown
MIT License
98 stars 21 forks source link

Bug: `options` argument is ignored #4

Closed yuki-takei closed 6 years ago

yuki-takei commented 6 years ago

Environment

Summary

According to README.md, the usage is

var md = require('markdown-it')()
            .use(require('markdown-it-plantuml')[, options]);

But the current code is following

function umlPlugin(md, name, options) {

Therefore, options object that specified as the second argument is ignored. Additionally, name variable is unused.

gmunguia commented 6 years ago

Nice catch. Thanks!

gmunguia commented 6 years ago

FYI: published patch as v0.3.2.