search

gmusic-utils / gmusic.js

Browser-side JS library for controlling Google Music
The Unlicense
54 stars 7 forks source link

README still mentions built files #13

Closed arkon closed 7 years ago

arkon commented 8 years ago

The README mentions that you can use the library by just linking to the built file from here on GitHub, but the contents of dist/ aren't actually here.

jostrander commented 8 years ago

That's actually for an older version and should be amended to not say that. When we ported to es6 we decided that storing dist in git was a bad idea.

bichotll commented 7 years ago

So what's the story with bower? Bower.json has not been updated since 5.X. Also, releases does not have build folder either.

Unfortunately, I'm still using bower...:/

MarshallOfSound commented 7 years ago

Unfortunately, I'm still using bower...:/

bower is not a supported install method anymore, due to use not storing the dist in version control

x3haloed commented 7 years ago

Since we can't download the built version from dist anymore, can you please provide up-to-date build/transpile instructions? I tried to guess now it should work, but I couldn't figure it out. I installed gulp and babel, and I ran gulp build, but babel threw an error about the syntax in gmusic.js being wrong.

arkon commented 7 years ago

What exactly is the syntax error?

jostrander commented 7 years ago

You should be able to run npm install and npm run build after a fresh clone, but I would like to see the syntax error as well.

arkon commented 7 years ago

On a related note, I think the bower instructions should be removed as well, based on the past conversation here.

jostrander commented 7 years ago

PR? ;)

x3haloed commented 7 years ago

Running npm install and npm run build on a fresh clone worked. I must have messed up the babel config before.

Thank you for your help!