search

gmusic-utils / ytmusic.js

The Unlicense
9 stars 4 forks source link

Issue with playback buttons #24

Closed bruno-brant closed 3 years ago

bruno-brant commented 3 years ago

It seems YT Music changed some CSS styles that are being used by ytmusic.js to select the playback ("media") buttons, as can be seem from my post at GPMDP issues.

I did just some preliminary testing, but it seems that what happened was simple: YT dropped the left-controls and right-controls classes from the buttons. The fix is simple enough, but I'd like to see if repo contributors can confirm that this was the change, since I have no background on this lib and am only superficially analyzing the issue.

jostrander commented 3 years ago

image I'm still seeing these classes present, however, I may not be selected to receive the new web version yet, as Google usually does staged rollouts of changes.

bruno-brant commented 3 years ago

Hmm, it seems I made a stupid mistake, I inverted the classes in the query. The classes are there. I'm not sure why it wouldn't be working.

jostrander commented 3 years ago

Fixed in 86f4a430fac5e4ecf357c2719858b33d760c524b, closing. GPMDP will need to pull this change in.