Move from mocha-phantomjs to mocha-chrome for tests

gnab / remark

A simple, in-browser, markdown-driven slideshow tool.

http://remarkjs.com

MIT License

12.68k stars 856 forks source link

Move from mocha-phantomjs to mocha-chrome for tests #594

Closed peterj closed 4 years ago

peterj commented 4 years ago

The PhantomJS and mocha-phantomjs projects have been deprecated and the mocha-chrome is a suggested project to migrate to. I wasn't able to get the mocha-phantomjs to work locally, and the CI was failing due to phantomjs as well. Still need to test that this works on Windows (works fine on MacOS).

peterj commented 4 years ago

One drawback - mocha-chrome is only supported for Node 7.X only... We still run tests with Node 6 though