search

gnab / remark

A simple, in-browser, markdown-driven slideshow tool.
http://remarkjs.com
MIT License
12.68k stars 856 forks source link

keypress is deprecated #599

Open dvberkel opened 4 years ago

dvberkel commented 4 years ago

While I was working on issue #195 I have read into the Mozilla's Developer Network (MDN) documentation on the keypress event. It reports that the event is deprecated.

This feature is no longer recommended. Though some browsers might still support it, it may have already been removed from the relevant web standards, may be in the process of being dropped, or may only be kept for compatibility purposes. Avoid using it, and update existing code if possible; see the compatibility table at the bottom of this page to guide your decision. Be aware that this feature may cease to work at any time.

peterj commented 4 years ago

Good find! Looks like both keydown and keypress events are used in keyboard.js.

dvberkel commented 4 years ago

I could start making a plan for the conversion if that is helpful