search

gnab / remark

A simple, in-browser, markdown-driven slideshow tool.
http://remarkjs.com
MIT License
12.68k stars 856 forks source link

highlightSpans behaves incorrectly in the presence of ( #616

Open nrinaudo opened 4 years ago

nrinaudo commented 4 years ago

The presence of ( near a highlighted span yields odds behaviours:

For example: case `class Token`( will include the ( in the highlighted region - no matter how many spaces are inserted before it.

This does not occur if you replace the ( by, say, a {.

dvberkel commented 4 years ago

@nrinaudo could you point to an example of the problem you are experiencing?

nrinaudo commented 4 years ago

I do not mean this to be snarky, but: what more do you want than the example I’ve given you? Should I present it in terms of input slides and screenshot of the output?

dvberkel commented 4 years ago

No snarky-ness is assumed. I was not familiar with highlighting functionality that is all. The project has attracted new maintainers recently. So not every one is is aware of all the functionality.

Having read the wiki on the topic, I now understand your problem.

We will take some time to figure out why this occurs.

nrinaudo commented 4 years ago

Do not hurry on my account, I worked around it for my own problem. This was just meant as a record of the issue, so that you're aware of it and can tackle it if and when convenient.