gnachman / iterm2-website

Website for iTerm2
http://iterm2.com/
GNU General Public License v2.0
80 stars 66 forks source link

Uncorrect characters displayed in changelog #100

Open aphedges opened 1 month ago

aphedges commented 1 month ago

I was reading the changelog for 3.5.0 in Firefox (https://iterm2.com/downloads/stable/iTerm2-3_5_0.changelog), and I noticed the text ⋯, which clearly looks like an encoding problem. I checked the line in the repository, which displays it as :

https://github.com/gnachman/iterm2-website/blob/df1ff9f3b7862e8fc00c4825254b45cd3983df38/downloads/stable/iTerm2-3_5_0.changelog#L39

I'm not 100% sure how to solve this, but I suspect that Firefox defaults to a non-UTF-8 encoding when one is not specified. This can probably be solved if you set the Content-Type header. A value like Content-Type: text/plain; charset=utf-8 would probably solve the problem, but I don't have a good way of testing this.

gnachman commented 1 month ago

I fought with Apache for a while but I can't get it to set the character set to UTF-8 for some reason. I put this in the .htaccess file:

AddCharset UTF-8 .changelog

but it had no effect. It does respect the redirects there so I know it's reading it.

aphedges commented 1 month ago

I have no clue, either. I have no experience with Apache httpd at all. However, I found two things that might help:

I tried to test both of these locally, but I couldn't figure out how to properly set up this site on my machine.