gnachman / iterm2-website

Website for iTerm2
http://iterm2.com/
GNU General Public License v2.0
81 stars 65 forks source link

Improve stty handling in it2check and it2getvar #49

Closed elyscape closed 6 years ago

elyscape commented 6 years ago

This copies the more robust handling of stty from it2ul to it2check and it2getvar. Trapping the stty restoration on EXIT means we're covered in all situations that might cause the script to exit early, not just the user hitting Ctrl+C, and means we don't need to remember to do it in the script's happy path. Accordingly, this fixes an issue in which it2getvar did not restore the stty settings if execution completed without issue.

gnachman commented 6 years ago

Thanks!

elyscape commented 6 years ago

@gnachman Any idea when you'll have this and #51 rolled out to the website?

gnachman commented 6 years ago

As soon as a new beta goes out. I should do that this weekend

elyscape commented 6 years ago

Sounds good. Thanks!