search

gnachman / iterm2-website

Website for iTerm2
http://iterm2.com/
GNU General Public License v2.0
81 stars 65 forks source link

AboutWindow bug fix #92

Closed cf512 closed 2 years ago

cf512 commented 2 years ago

There is a cosmetic issue in the iTermAboutWindow where line spacing, the font, and/or other styling gets thrown off by unique characters in the patrons list, starting with ＊ in Emily St＊ and ending with ř in Ondřej Surý :

Screenshot

This string appears to be fetched etc from the static file patrons.txt on iterm2-website.

This pull request simply removes and/or updates the unique characters. Submitting as a draft because I have been unable[1] to successfully build iTerm2 locally with Xcode to test this change by linking to a local edited version of patrons.txt.

No doubt there is more than one way to resolve this. If I could run locally, would be happy to tinker with iTermAboutWindowController.m to come up with something more robust and future-proof (plus work on some other open issues too).

But until then, all signs seem to point to these edits being a quick and easy solution.

More about build errors:

[1]: Followed steps at https://gitlab.com/gnachman/iterm2/-/wikis/HowToBuild (and stackexchange posts galore) but am stuck on the following build errors:

Errors

Running:

There may be something very basic that I'm missing due to being new with Xcode and Swift. Or could be that the HowToBuild steps (last updated 11 months ago) may no longer be accurate. It would appear I am not alone on this build issue: https://gitlab.com/gnachman/iterm2/-/issues/9993#note_834296482 and it would also appear that maybe this won't be an issue in the future depending how things go here: https://github.com/gnachman/iTerm2/pull/460

gnachman commented 2 years ago

Thanks for the PR! I don't think I can merge this because I don't want to spell peoples' names differently than they prefer. I'm fixing the build to work with Xcode 13.2 (I had stayed on 13.1 because of some awful bugs in 13.2, but I think they're fixed in 13.2.1).

gnachman commented 2 years ago

Commit 2ce1c6ae7 fixes the variable line height; we just need to change the emoji star in Emily St * to a normal asterisk. Please update the PR to do that and I can merge it.

cf512 commented 2 years ago

Thanks George. PR updated.