search

gnahtb / RealFL

Implement basic steps in a model-centric federated learning model
The Unlicense
0 stars 2 forks source link

Cifar10Repository in server does not comply with single responsibility principle #26

Closed gnahtb closed 1 year ago

gnahtb commented 1 year ago

Same as what is mentioned in #24. Check https://github.com/bnnthang/RealFL/blob/a58ff2b0a21876baa608cedce62f225a053203a7/Server/src/main/java/com/bnnthang/fltestbed/Server/Repositories/Cifar10Repository.java.

gnahtb commented 1 year ago

Partially fixed in commit c47ccf5.

@tem556 Please check and complete replacing other places. This has a lower priority than other issues.

tem556 commented 1 year ago

@bnnthang I believe this issue can be closed now