search

gnames / gnverifier

GNverifier verifies scientific names against more than 100 biodiversity databases
https://verifier.globalnames.org
MIT License
19 stars 1 forks source link

bug? (also propagated to old releases) #90

Closed Adafede closed 2 years ago

Adafede commented 2 years ago

Hi @dimus !

Following your last updates, I am quite confused. I am facing strange behaviors I can't explain...

Here are some trials to diagnose:

➜  lotus-processor git:(main) ✗ bin/gnverifier -V                                         

version: v0.8.2
build: 2022-02-25_22:48:34UTC

➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida"        
00:38:27 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -s 0   
00:38:39 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
SortedMatch,0.0,NoMatch,,Iris pallida,,,,,,,,,
➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -M  
00:38:51 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Salisb., nom. illeg.",Iris pallida,3PZY5,Iris halophila Pall.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris halophila,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Ten., nom. illeg.",Iris pallida,3PZY4,Iris germanica L.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris germanica,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Salisb.,Iris pallida,100206633,Iris pallida Salisb.,false,165,Tropicos,,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Ten.,Iris pallida,438940-1,Iris pallida Ten.,false,167,IPNI,Iridaceae|Iris|Iris pallida,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Salisb.,Iris pallida,438941-1,Iris pallida Salisb.,false,167,IPNI,Iridaceae|Iris|Iris pallida,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,16602434,Iris pallida Lam.,false,165,Tropicos,,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,20378s,Iris pallida Lam.,false,6,GRIN Taxonomy for Plants,Plant|Iridaceae|Iris|Iris pallida,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,43223,Iris pallida Lam.,false,3,ITIS,Plantae|Viridiplantae|Streptophyta|Embryophyta|Tracheophyta|Spermatophytina|Magnoliopsida|Lilianae|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,438939-1,Iris pallida Lam.,false,167,IPNI,Iridaceae|Iris|Iris pallida,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,438939-1,Iris pallida Lam.,false,197,World Checklist of Vascular Plants,Tracheophyta|Iridaceae|Iris|Iris pallida,
SortedMatch,8.98344,Exact,0,Iris pallida,Iris × pallida Ten.,Iris × pallida,100207085,Iris × pallida Ten.,false,165,Tropicos,,
SortedMatch,8.98202,Exact,0,Iris pallida,Iris pallida Salisb.,Iris pallida,438941-1,Iris halophila Pall.,true,197,World Checklist of Vascular Plants,Tracheophyta|Iridaceae|Iris|Iris halophila,
SortedMatch,8.98155,Exact,0,Iris pallida,Iris × pallida Ten.,Iris × pallida,438940-1,Iris × germanica L.,true,197,World Checklist of Vascular Plants,Tracheophyta|Iridaceae|Iris|Iris germanica,
SortedMatch,8.98012,Exact,0,Iris pallida,Iris pallida,Iris pallida,49342,Iris pallida,false,2,Wikispecies,,
SortedMatch,8.95257,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,144905279,Iris pallida Lam.,false,158,EUNIS,,
SortedMatch,8.95257,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,5298086,Iris pallida Lam.,false,11,GBIF Backbone Taxonomy,Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.95257,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,wfo-0000783695,Iris pallida Lam.,false,196,World Flora Online,Angiosperms|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.95053,Exact,0,Iris pallida,Iris pallida Ten.,Iris pallida,7481938,Iris germanica L.,true,11,GBIF Backbone Taxonomy,Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris germanica,
SortedMatch,8.95053,Exact,0,Iris pallida,Iris pallida Salisb.,Iris pallida,8390855,Iris halophila Pall.,true,11,GBIF Backbone Taxonomy,Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris halophila,
SortedMatch,8.95053,Exact,0,Iris pallida,Iris pallida Salisb.,Iris pallida,wfo-0000783697,Iris halophila Pall.,true,196,World Flora Online,Angiosperms|Asparagales|Iridaceae|Iris|Iris halophila,
SortedMatch,8.94951,Exact,0,Iris pallida,Iris ×pallida Ten.,Iris × pallida,wfo-0000783696,Iris ×germanica L.,true,196,World Flora Online,Angiosperms|Asparagales|Iridaceae|Iris|Iris germanica,
SortedMatch,8.94848,Exact,0,Iris pallida,Iris pallida,Iris pallida,259588,Iris pallida,false,179,Open Tree of Life,||Eukaryota|Archaeplastida|Chloroplastida|Streptophyta|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
SortedMatch,8.94848,Exact,0,Iris pallida,Iris pallida,Iris pallida,490956,Iris pallida,false,12,EOL,,
SortedMatch,8.94848,Exact,0,Iris pallida,Iris pallida,Iris pallida,gn_1410993,Iris pallida,false,170,Arctos,Plantae|Tracheophyta|Liliopsida|Liliales||Iris|Iris pallida,
SortedMatch,8.94643,Exact,0,Iris pallida,Iris pallida,Iris pallida,'gn_618164',Iris germanica,true,170,Arctos,Plantae|Tracheophyta|Liliopsida|Liliales||Iris|Iris germanica,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lamarck,Iris pallida,6182,Iris pallida Lamarck,false,147,VASCAN,Equisetopsida|Magnoliidae|Lilianae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris subgenus|Iris pallida,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,10900062,Iris pallida Lam.,false,8,IRMNG (old),Plantae|Magnoliophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,131538753,Iris pallida Lam.,false,166,nlbif,,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,141678075,Iris pallida Lam.,false,164,BioLib.cz,,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,142477782,Iris pallida Lam.,false,150,USDA NRCS PLANTS Database,,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,94075872,Iris pallida Lam.,false,169,uBio NameBank,|Iris pallida,
SortedMatch,8.91878,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,gn-70233dd2-5973,Iris pallida Lam.,false,198,Leipzig Cat. Vasc. Plants,Tracheophyta|Asparagales|Iridaceae|Iris pallida,
SortedMatch,8.91657,Exact,0,Iris pallida,Iris pallida Salisb.,Iris pallida,gn-c720383f-7802,Iris halophila Pall.,true,198,Leipzig Cat. Vasc. Plants,Tracheophyta|Asparagales|Iridaceae|Iris halophila,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,/en/iris_pallida,Iris pallida,false,10,Freebase,Eukaryota|Plantae|Embryophyta|Spermatophyta|Magnoliophyta|Liliopsida|Liliidae|Liliales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,164131,Iris pallida,false,180,iNaturalist,Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,29817,Iris pallida,false,4,NCBI,|Eukaryota|Viridiplantae|Streptophyta|Streptophytina|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,95872265,Iris pallida,false,169,uBio NameBank,|Iris pallida,
➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -s 1,2,3,4,179 -M
00:39:26 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Salisb., nom. illeg.",Iris pallida,3PZY5,Iris halophila Pall.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris halophila,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Ten., nom. illeg.",Iris pallida,3PZY4,Iris germanica L.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris germanica,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,43223,Iris pallida Lam.,false,3,ITIS,Plantae|Viridiplantae|Streptophyta|Embryophyta|Tracheophyta|Spermatophytina|Magnoliopsida|Lilianae|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.98012,Exact,0,Iris pallida,Iris pallida,Iris pallida,49342,Iris pallida,false,2,Wikispecies,,
SortedMatch,8.94848,Exact,0,Iris pallida,Iris pallida,Iris pallida,259588,Iris pallida,false,179,Open Tree of Life,||Eukaryota|Archaeplastida|Chloroplastida|Streptophyta|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,29817,Iris pallida,false,4,NCBI,|Eukaryota|Viridiplantae|Streptophyta|Streptophytina|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -s 1,2,3,4,179   
00:40:14 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,

I would say:

Sorry I can't help more... happy to further test/develop

dimus commented 2 years ago

hi @Adafede, thanks for submitting it

yes you are right, I just released a new version of gnames, where I tried to fix a few inconsistencies in API, and as a result v0.8.0 has quite a few breaking changes, sorry about adding extra work for you, but I think in a long run these changes will be justified. Please read https://github.com/gnames/gnames/releases/tag/v0.8.0

The purpose of most of these changes was to bring search and verification behavior to almost identical. Before "data-sources" option as well as "show all matches" option behaved differently and it was very confusing. In short:

-s 0 option does not exist at all anymore, it is the default behavior now. -s N,N2,N3 option now limits search to provided data-sources -M option now shows all results

BestResult in csv/tsv format indicates the best result for a name SortedMatch shows all other results, and, as you see, they are sorted, and there is new field 'SortScore' that illustrates the numbers that were used for sorting.

Again apologies for breaking changes, there are quite a few of them, because I tried to put all of them into one release, so I do not break others scripts too often. I hope it is now close to stabilizing, but until /api/v0 will be /api/v2 I will listen for suggestions on improving API.

dimus commented 2 years ago

At the start of the next week I will make a blog post that will explain the changes I made.

Adafede commented 2 years ago

No problems, I know it is for the good! 😉

My question is regarding -s 1,2,3. To me, it should work without -M but it does not, am I right?

➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -s 1,2,3,4,179   
00:40:14 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
dimus commented 2 years ago

can you show the version of gnverifier?

With v0.8.2 I get:

✦ ❯ gnverifier "Iris pallida" -s 1,2,3,4,179
18:09:18 INF Using config file: /home/dimus/.config/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,

It shows best result only, and with -M I get all of them

✦ ❯ gnverifier "Iris pallida" -s 1,2,3,4,179 -M -q
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Salisb., nom. illeg.",Iris pallida,3PZY5,Iris halophila Pall.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris halophila,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Ten., nom. illeg.",Iris pallida,3PZY4,Iris germanica L.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris germanica,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,43223,Iris pallida Lam.,false,3,ITIS,Plantae|Viridiplantae|Streptophyta|Embryophyta|Tracheophyta|Spermatophytina|Magnoliopsida|Lilianae|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.98012,Exact,0,Iris pallida,Iris pallida,Iris pallida,49342,Iris pallida,false,2,Wikispecies,,
SortedMatch,8.94848,Exact,0,Iris pallida,Iris pallida,Iris pallida,259588,Iris pallida,false,179,Open Tree of Life,||Eukaryota|Archaeplastida|Chloroplastida|Streptophyta|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,29817,Iris pallida,false,4,NCBI,|Eukaryota|Viridiplantae|Streptophyta|Streptophytina|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
Adafede commented 2 years ago

Here:

➜  lotus-processor git:(main) ✗ bin/gnverifier -V                                                                        

version: v0.8.2
build: 2022-02-25_22:48:34UTC

➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -s 1,2,3,4,179                                             
01:11:35 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
➜  lotus-processor git:(main) ✗ bin/gnverifier "Iris pallida" -s 1,2,3,4,179 -M
01:11:45 INF Using config file: /Users/rutza/Library/Application Support/gnverifier.yaml.
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,9.01315,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,3PZY6,Iris pallida Lam.,false,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Salisb., nom. illeg.",Iris pallida,3PZY5,Iris halophila Pall.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris halophila,
SortedMatch,9.01005,Exact,0,Iris pallida,"Iris pallida Ten., nom. illeg.",Iris pallida,3PZY4,Iris germanica L.,true,1,Catalogue of Life,Biota|Plantae|Tracheophyta|Liliopsida|Asparagales|Iridaceae|Iris|Iris germanica,
SortedMatch,8.98392,Exact,0,Iris pallida,Iris pallida Lam.,Iris pallida,43223,Iris pallida Lam.,false,3,ITIS,Plantae|Viridiplantae|Streptophyta|Embryophyta|Tracheophyta|Spermatophytina|Magnoliopsida|Lilianae|Asparagales|Iridaceae|Iris|Iris pallida,
SortedMatch,8.98012,Exact,0,Iris pallida,Iris pallida,Iris pallida,49342,Iris pallida,false,2,Wikispecies,,
SortedMatch,8.94848,Exact,0,Iris pallida,Iris pallida,Iris pallida,259588,Iris pallida,false,179,Open Tree of Life,||Eukaryota|Archaeplastida|Chloroplastida|Streptophyta|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,
SortedMatch,8.91436,Exact,0,Iris pallida,Iris pallida,Iris pallida,29817,Iris pallida,false,4,NCBI,|Eukaryota|Viridiplantae|Streptophyta|Streptophytina|Embryophyta|Tracheophyta|Euphyllophyta|Spermatophyta|Magnoliopsida|Mesangiospermae|Liliopsida|Petrosaviidae|Asparagales|Iridaceae|Iridoideae|Irideae|Iris|Iris pallida,

I would expect the -Mresult without the -M.

And with -Mto actually obtain possible multiples per source

dimus commented 2 years ago

Ah, yes, I understood now. It is the change in verification procedure. It works like this now:

no flags -- searches everything, returns best -s flag -- searches only data-sources that you want and returns only best result. The result is limited to provided data-sources -M -- shows everything found

Adafede commented 2 years ago

Nothing, read too quick!

What I want was -s 1,2,3 -M so! Thanks a lot!

dimus commented 2 years ago

An option to pick only best result per data-source: I can add it if i get a request. Did I get a request from you? ;)

I did not add it, because it is easy to pick the first result for each source using a script. So I am waiting for a request from people to have this option again.

Adafede commented 2 years ago

Hmmm...isn't it what -s 1,2,3 -M is doing?

dimus commented 2 years ago

Only if there is just one match per source. For example:

✦ ❯ gnverifier "Jsoetes longissimum" -s 158 -M -q
Kind,SortScore,MatchType,EditDistance,ScientificName,MatchedName,MatchedCanonical,TaxonId,CurrentName,Synonym,DataSourceId,DataSourceTitle,ClassificationPath,Error
BestMatch,8.79803,Fuzzy,1,Jsoetes longissimum,Isoetes longissimum Bory,Isoetes longissimum,144750512,Isoetes longissimum Bory,false,158,EUNIS,,
SortedMatch,7.96012,Fuzzy,3,Jsoetes longissimum,Isoetes longissima Bory,Isoetes longissima,144848706,Isoetes longissima Bory,false,158,EUNIS,,

returns several

Adafede commented 2 years ago

I see, no problem to filter per best score in a small script as you mentioned to me, so no request your work is consequent enough! 😄

Adafede commented 2 years ago

Hmmm...last annoying question, how can I obtain the equivalent of gnverifier "Iris pallida" -s 1,2,3,4,179 -M -q using gnfinder? I think there is no -M in gnfinder

Adafede commented 2 years ago

Fine no worries, I'll do "old school", running gnverifier on the top of gnfinder as long time ago in the meantime :)

dimus commented 2 years ago

Added https://github.com/gnames/gnfinder/issues/116