search

gnarlinsky / fab-lab-signin

Sign in to the Fab Lab space and other things
1 stars 0 forks source link

Unexpected behavior when checking "Project," "For a class," and "Other" #34

Closed gnarlinsky closed 10 years ago

gnarlinsky commented 10 years ago

The toggle (check checkbox, others are revealed) for these fields does not ​ ​behave as expected when the text is clicked on rather than the actual checkbox.​ ​ In that case, the checkbox does get checked, but the additional fields are not revealed (see screenshot 1). Clicking in the checkbox again does reveal the additional items -- but the check itself is gone (see screenshot 2), meaning that whatever the user checks or inputs in the additional fields​​ won't get saved. Clicking in the checkbox again does put the check there, but also hides the additional fields again. (1)
screenshot from 2013-12-01 14 09 59

(2) screenshot from 2013-12-01 14 11 58

gnarlinsky commented 10 years ago

Solved by tying the toggle visibility functionality to the relevant checkbox rather than checkbox and label. (The functionality where the user can click on the label in order to check the checkbox does get preserved, which is nice.) (Resolved in develop branch)