document connection keepalive and connection limit ?

gnarroway / hato

An HTTP client for Clojure, wrapping JDK 11's HttpClient

MIT License

380 stars 27 forks source link

document connection keepalive and connection limit ? #37

Closed henryw374 closed 2 years ago

henryw374 commented 3 years ago

i needed to set these and it turns out they are only set-able globally via system props, see

https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java#L54

took a while to track down... and tbh if I realised this before I might have chosen to use clj-http instead. could be worth adding to the readme?

gnarroway commented 2 years ago

Thanks for raising. Closing this as the options have always been documented ("Other advanced options" at the bottom of the readme). In future I might make it more clear that they can't be set directly per client.