Closed asmattic closed 4 months ago
All non wagmi
related packages updated to next major versions.
Not sure exactly where the hardhat error is originating, if it just needs the .env
keys in Vercel but the webapp
builds without errors locally.
yeah no worries, as long as web builds we're good. will review today
All added formatting unrelated to PR removed. Local webapp build confirmed still working.
Removed .npmrc
files. Kept node@v18.20.2
(see comments). Tested local webapp
builds with all other changes requested.
Also let's rebase off the most recent merge
After looking again it looks like you ran
asmattic/main
locally and notasmattic/package-updates
which is the branch for this PR.
Vercel preview is only for the given branch. Didnt see the branch change, let's limit that in the future or close and open a new pr.
Vercel preview is only for the given branch. Didnt see the branch change, let's limit that in the future or close and open a new pr.
I'll make sure to have main
as the comparison fork branch for future PR's. In the interest of not creating a 3rd PR for this issue I think we should wrap up this issue here.
I just need preview build logs to locate and debug the cause of the webapp
build error produced.
for commit hash ae732f9
the vercel logs dont reveal anything here that wasnt determinable on local?
ae732f9
Thanks, I'll debug from there and try and replicate locally. I'll request re-review when I have tracked down the root cause.
Dependency connectkit@^1.5.1
was pulling in connectkit@1.7.x
(see breaking changes here)[https://docs.family.co/connectkit/migration-guide#section-170-breaking-changes-update-packages] which requires wagmi@v2
. The alchemyId
error was an artifact of the wagmi@v2
larger upgrade due to the connectkit
relation.
Replicated the alchemyId
type error removing pnpm-lock.yaml
in root and running pnpm install
and build
in webapp
below where you can see the connectkit
breaking version.
Fixing connectkit
to v1.5.1
resolves this issue and runs a successful build. I'll avoid post another local build screenshot, lol.
I'm pretty confident if another build error occurs, it'll at least be a new one.
🔥
Issue
Notes
next
frompages
toapp
router here. Next 14 is backwards compatible and designed to be migrated as needed if/when that is something we decide to prioritize. It's not too large a task, but testing for that should be a stand alone effort/PR IMO.Acceptance Criteria