search

gnars-dao / gnars-frontend

https://gnars.wtf
15 stars 9 forks source link

feat: Add BASE to Proposals page #43

Closed 0xMillz closed 2 months ago

0xMillz commented 2 months ago

Closes half of issue 22 (#22). Finishes the dao/proposals page and is completely backwards compatible, linking Ethereum proposals to their gnars.wtf pages and Base proposals to nouns.build.

Preview: https://gnars-frontend-opal.vercel.app/dao

Screenshot 2024-08-09 at 6 50 35 AM Screenshot 2024-08-09 at 6 51 06 AM
sktbrd commented 2 months ago

Thanks mills!

0xMillz commented 2 months ago

main gripe is with EffectiveProposalStatus | string type

Yeah, I don't like it either but they have different proposal 'states' as they call them and I didn't really want to get in the weeds so for MVP so simply adding | string makes it forwards and backwards compatible. Probably something I can "drive-by" refactor as I'm coding in my next PR