gnars-dao / gnars-frontend

https://gnars.wtf
15 stars 10 forks source link

add SSR for legacy Ethereum proposals graph query #48

Closed 0xMillz closed 4 weeks ago

0xMillz commented 1 month ago

Deployed here: gnars-frontend-f6f0slrw5-gnars.vercel.app

Visual difference for the code, Only 1 client-side request for proposals vs 6 in 15 seconds on the same /dao page: image

I also realized "pending" still means "active" so fixed that along with a lot of other legacy code I ripped out

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gnars-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 19, 2024 6:50pm
gnars-frontend-4xsc ❌ Failed (Inspect) 💬 Add feedback Aug 19, 2024 6:50pm
vercel[bot] commented 1 month ago

@0xMillz is attempting to deploy a commit to the Gnars Team on Vercel.

A member of the Team first needs to authorize it.

asmattic commented 1 month ago
image

@0xMillz

When I click DAO on the top nav there's a serious error loop. This is after only a few seconds, it was climbing fast.

bagelface commented 1 month ago
image

@0xMillz

When I click DAO on the top nav there's a serious error loop. This is after only a few seconds, it was climbing fast.

any steps to recreate this issue? not seeing it on the vercel deployment. is this only when you run it locally?

asmattic commented 1 month ago
image

@0xMillz When I click DAO on the top nav there's a serious error loop. This is after only a few seconds, it was climbing fast.

any steps to recreate this issue? not seeing it on the vercel deployment. is this only when you run it locally?

I found the issue. It's the frontend start a thread tool. If you highlight something and don't start a thread it will rack up those errors until exited out. So nothing to do with the PR changes.

bagelface commented 1 month ago
image

@0xMillz When I click DAO on the top nav there's a serious error loop. This is after only a few seconds, it was climbing fast.

I noticed it once, and I think I traced coming from my MetaMask extension

probably just an RPC error then