search

gnaudio / jabra-browser-integration

JavaScript library to control a Jabra headset from a browser
https://www.npmjs.com/package/@gnaudio/jabra-browser-integration
MIT License
3 stars 1 forks source link

Fail signfile.cmd if there is an error in running signtoool.exe #68

Closed JKrag closed 4 years ago

JKrag commented 4 years ago

I noticed that the build pipeline silently swallows a failed attempt to sign. This is because the signfile.cmd ends with an "echo Done", so the return code is always 0. I have now added an error check and early exit.