gnaudio / jabra-node-sdk

Jabra Node.Js SDK based on N-API
https://www.npmjs.com/package/@gnaudio/jabra-node-sdk
MIT License
0 stars 1 forks source link

Updating Node-gyp bindings file #50

Closed dlaezza-jabra closed 4 years ago

dlaezza-jabra commented 4 years ago

The bindings.gyp could definitely use some love. This is a small refactoring, aiming to:

ghost commented 4 years ago

Great - this has been something on my wishlist for a while :-) Just be careful to test this very well.

dlaezza-jabra commented 4 years ago

What do you mean by testing it well? I can only think of trying it on windows, both on our machines and in the Azure cloud (we set up a pipeline, as you maybe can see)

tfroehlich-jabra commented 4 years ago

Windows and Mac look good, but I don't see any Linux changes?

dlaezza-jabra commented 4 years ago

This is a work-in-progress. I wanted to test whether this built on the cloud, and the easiest way I found so far is to make a pull request