search

gnaudio / jabra-node-sdk

Jabra Node.Js SDK based on N-API
https://www.npmjs.com/package/@gnaudio/jabra-node-sdk
MIT License
0 stars 1 forks source link

Added Store/ApplyColorControlPreset wrappers #69

Closed martin-jabra closed 4 years ago

dlaezza-jabra commented 4 years ago

The build error is typically due to outdated binaries (yes, on WIndows the SDK binary is compiled together with some obscure stuff into a DLL, so the new binary is required to build). I assume you'll fix that before merging

martin-jabra commented 4 years ago

Should the DLL be updated here before merging into py-release? Reason is that py-release is pending a release binary update before it will be merged to master and I am not sure my local builds are the ones that will be used anyway (I assume there is some c-api release pipeline that supplies these).

tfroehlich-jabra commented 4 years ago

I think we should aim towards getting the pipeline to pass even though it's just temporary binaries.