search

gnea / grbl

An open source, embedded, high performance g-code-parser and CNC milling controller written in optimized C that will run on a straight Arduino
https://github.com/gnea/grbl/wiki
Other
3.98k stars 1.59k forks source link

Implementing feed/spindle speed override by analog input #1227

Open leonerd opened 8 months ago

leonerd commented 8 months ago

I see a lot of questions asking variations on the theme of using analog inputs to override speeds; likely because people want to connect front-panel potentiometers or other such.

I understand no such feature currently exists.

Would the developers be open to accepting a PR to implement such a thing? I've done much AVR work on the 328p so I suspect I could have a good look at it. I know the flash space is entirely filled at this point so it would have to be a compile conditional feature that is not enabled by default; but maybe people who'd want such a thing could enable it and disable something else they wouldn't need - for example, laser mode (as surely folks who know they have a CNC mill aren't going to need laser mode on such a machine).

In any case I may have a go at doing it myself sometime anyway, but I'd ideally like to do so in a way that can eventually be contributed back upstream to be more useful to more folks.

What would opinions be?

cri-s commented 8 months ago

As i have made it, but on hw side. LTC6900 with 100k potentiometer and 10k resistor in order to have a range of 1Mhz to 20Mhz. For the commands, i'm passed from rs232 to i2c, but at the same time it was possible to use a small 8pin uc to convert i2c to rs232 and feed it to the grbl controller. For rs232 to i2c, i'm just using pic 10f because i just had it.

Am Di., 10. Okt. 2023 um 17:44 Uhr schrieb Paul Evans @.***>:

I see a lot of questions asking variations on the theme of using analog inputs to override speeds; likely because people want to connect front-panel potentiometers or other such.

I understand no such feature currently exists.

Would the developers be open to accepting a PR to implement such a thing? I've done much AVR work on the 328p so I suspect I could have a good look at it. I know the flash space is entirely filled at this point so it would have to be a compile conditional feature that is not enabled by default; but maybe people who'd want such a thing could enable it and disable something else they wouldn't need - for example, laser mode (as surely folks who know they have a CNC mill aren't going to need laser mode on such a machine).

In any case I may have a go at doing it myself sometime anyway, but I'd ideally like to do so in a way that can eventually be contributed back upstream to be more useful to more folks.

What would opinions be?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

pixelwaster commented 8 months ago

Sadly, From the wiki - Attention: This project is discontinued and has not recceived new commits or accepted pull requests since Aug 30, 2019.