search

gnebbia / kb

A minimalist command line knowledge base manager
GNU General Public License v3.0
3.17k stars 104 forks source link

Add homebrew support #17

Closed kgadek closed 4 years ago

kgadek commented 4 years ago

Loosely related to #15.

I've created Homebrew tap with kb formula. I'd be happy to transfer this file (or even repo since there's only kb.rb there now) to you if you want. For now, with no pip package, it takes package from a repo.

Repo url: https://github.com/kgadek/homebrew-tools

Installation procedure using repo (tested on macOS):

brew tap kgadek/tools
brew install kgadek/tools/kb

Note: I'm definitely not an expert in Homebrew. It seems to work but definitely could get improvements. E.g. it doesn't pass brew audit ("1: col 1: Missing frozen string literal comment").

gnebbia commented 4 years ago

Thanks a lot Sir, could you please please investigate this brew audit error? It would better to fix it. It would be nice to open a pull request to add this. Actually since I don't know much about brew, I even have no idea on how to publish this for brew.

If you help me I can add you to the list of contributors! Thanks again!

kgadek commented 4 years ago

Comparing original proposal to #25:

  1. Instead of having separate repo, this will host the brew formula in this repo itself. The commands slightly change — brew tap will require two arguments, but that's a small price. In future it could be considered to make a PR to Homebrew-core with this, but this repo/project is too fresh for that now.
  2. Fixed brew-audit errors.
  3. Pinned repo clone to v0.1.2.

If #25 gets approved, I will remove kgadek/homebrew-tools repository — wouldn't be necessary anymore.

gnebbia commented 4 years ago

Thanks @kgadek that's awesome! I am closing this issue!