search

gnebbia / kb

A minimalist command line knowledge base manager
GNU General Public License v3.0
3.17k stars 104 forks source link

Improved Docker file #48

Closed alshapton closed 4 years ago

alshapton commented 4 years ago

Docker image bow builds with Alpine Linux, Python 3.8, nano and vim

What does this implement/fix? Explain your changes.

Improves Docker construct by using Python/Alpine Linus/Vim/Nano

Does this close any currently open issues?

Addresses some of the statements in issue#33

gnebbia commented 4 years ago

Ok just 2 minor problems: 1) I suggest to put the RUN as a single statement 2) The aliases are not working since alpine uses ash instead of bash... At the moment I wasn't able to make them work by using docker-compose exec without running a shell within the container.

gnebbia commented 4 years ago

so for the RUN you can do: RUN apk update && apk add nano vim

it is a convention in dockerfiles, this is used to not create additional docker layers within the container.