gnebbia / kb

A minimalist command line knowledge base manager
GNU General Public License v3.0
3.17k stars 104 forks source link

kb-API Project PR - READY #50

Closed alshapton closed 4 years ago

alshapton commented 4 years ago

What does this implement/fix? Explain your changes.

Does this close any currently open issues?

No, however, it does address items in the kbAPI project as specified above.

Any relevant logs, error output, etc?

None

Any other comments?

Updating the architecture of the code as per this comment

Where has this been tested?

Operating System: MacOS Catalina 10.15.7

Platform: Python 3.8.5 Docker 19.03.13 Docker-compose 1.27.4 Flask 1.1.2

gnebbia commented 4 years ago

OK cool! I think we still need to really separate the action functionality from the command functionality as possible... I mean, I expect the add command to be really small, since it should take advantage of the add functionality. I don't know if my explanation is clear... I mean, it would be cool to have most of the add functionality in the add action, since that's the core logic, while the add command should be really small and just calling the add action and probably some checks for the command line flags, nothing more.